search

spotify / ffwd

a flexible metric forwarding agent
https://spotify.github.io/ffwd/
Apache License 2.0
79 stars 33 forks source link

don't setDistributionTypeValue if the metric is not a distribution type #225

Closed samfadrigalan closed 3 years ago

samfadrigalan commented 3 years ago

The current way non-distribution metrics are being built conflicts with this condition in the consumer. This PR makes sure to only set the metric distribution_type_value if the metric is a distribution.

ao2017 commented 3 years ago

@samfadrigalan as discussed offline, the "if statement" can handle every type of metrics.
Since metrics generated by apollo are working fine. I think the problem is a data issue.

samfadrigalan commented 3 years ago

not needed