search

spotify / folsom

An asynchronous memcache client for Java
Apache License 2.0
147 stars 67 forks source link

Add TLS #230

Closed thiagocesarj closed 1 year ago

thiagocesarj commented 1 year ago

This PR continues the work from #202 and #227 and adds support for TLS connections.

thiagocesarj commented 1 year ago

@paralainer I have picked up the PR, did some small refactoring and triggered a build. We are seeing some SSL errors. More info on the details.

paralainer commented 1 year ago

@paralainer I have picked up the PR, did some small refactoring and triggered a build. We are seeing some SSL errors. More info on the details.

@thiagocesarj, I was going to fix PR comments, any reason to create a new PR instead of contributing to an existing one? It's open for contribution.

I'll fix PR comments in my PR and I have a good idea why it doesn't work on CI so I'll fix that as well.

thiagocesarj commented 1 year ago

@paralainer I have picked up the PR, did some small refactoring and triggered a build. We are seeing some SSL errors. More info on the details.

@thiagocesarj, I was going to fix PR comments, any reason to create a new PR instead of contributing to an existing one? It's open for contribution.

I'll fix PR comments in my PR and I have a good idea why it doesn't work on CI so I'll fix that as well.

@paralainer thank you, I will close this PR then! I had some free time yesterday and wanted to see if we could release it, as you mentioned it was a critical update. Feel free to @ me if you need someone to trigger the build.