search

spotify / heroic

The Heroic Time Series Database
https://spotify.github.io/heroic/
Apache License 2.0
848 stars 109 forks source link

Drop metric with row key length bigger than BT limit #686

Closed malish8632 closed 4 years ago

malish8632 commented 4 years ago

This change will drop metric with row key length longer than 4096 bytes. It will also create counter metric so we could alert on high numbers.

lmuhlha commented 4 years ago

Seems like checkstyle is still failing :(

codecov[bot] commented 4 years ago

Codecov Report

Merging #686 into master will increase coverage by 0.01%. The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #686      +/-   ##
============================================
+ Coverage     53.88%   53.90%   +0.01%     
- Complexity     2962     2966       +4     
============================================
  Files           726      726              
  Lines         19426    19454      +28     
  Branches       1279     1282       +3     
============================================
+ Hits          10468    10486      +18     
- Misses         8513     8521       +8     
- Partials        445      447       +2
Impacted Files Coverage Δ Complexity Δ
...istics/semantic/SemanticMetricBackendReporter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...potify/heroic/metric/bigtable/BigtableBackend.java 90.38% <55.55%> (-1.25%) 59.00 <1.00> (+2.00) :arrow_down:
...oic/statistics/noop/NoopMetricBackendReporter.java 92.30% <100.00%> (+0.64%) 7.00 <1.00> (+1.00)
...m/spotify/heroic/test/AbstractMetricBackendIT.java 98.36% <100.00%> (+0.13%) 29.00 <2.00> (+2.00)
...com/spotify/heroic/aggregation/simple/MinBucket.kt 44.44% <0.00%> (-11.12%) 4.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa29634...076a0d2. Read the comment docs.