search

spotify / heroic

The Heroic Time Series Database
https://spotify.github.io/heroic/
Apache License 2.0
848 stars 109 forks source link

Moving quota watcher clean up to cover all queries #693

Closed malish8632 closed 4 years ago

malish8632 commented 4 years ago

Moved the code to remove quota watcher at the beginning of end() method to make sure we cover all queries. Some failures would be keeping watchers in the hash and skewing global stats.

codecov[bot] commented 4 years ago

Codecov Report

Merging #693 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #693   +/-   ##
=========================================
  Coverage     53.84%   53.84%           
  Complexity     2966     2966           
=========================================
  Files           726      726           
  Lines         19473    19473           
  Branches       1287     1287           
=========================================
  Hits          10485    10485           
  Misses         8536     8536           
  Partials        452      452
Impacted Files Coverage Δ Complexity Δ
.../com/spotify/heroic/metric/LocalMetricManager.java 66.34% <100.00%> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5659d28...1eee6b6. Read the comment docs.