search

spotify / heroic

The Heroic Time Series Database
https://spotify.github.io/heroic/
Apache License 2.0
848 stars 109 forks source link

GitHub action workflow to build PRs in Docker images. #718

Closed hexedpackets closed 3 years ago

hexedpackets commented 3 years ago

I did this as GitHub actions instead of CircleCI because of how forks are handled. We want tests to run for every PR, regardless of source. We only want these Docker images to be automatically created for PRs originating from this repo, and not for forks. Doing that in CircleCI might be possible, but this way is simpler and has the benefit of building the image in parallel with the tests running in Circle.

Assuming this works well, we might want to also move our Docker Hub build actions to GitHub actions to reduce the number of places that CI is happening.

Closes #716.

codecov[bot] commented 3 years ago

Codecov Report

Merging #718 into master will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #718      +/-   ##
============================================
- Coverage     54.40%   54.36%   -0.05%     
+ Complexity     3052     3050       -2     
============================================
  Files           735      735              
  Lines         19866    19866              
  Branches       1304     1304              
============================================
- Hits          10808    10800       -8     
- Misses         8591     8601      +10     
+ Partials        467      465       -2
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/spotify/heroic/metrics/EWMA.java 58.33% <0.00%> (-20.84%) 4.00% <0.00%> (-1.00%)
...rc/main/java/com/spotify/heroic/metrics/Meter.java 68.96% <0.00%> (-17.25%) 6.00% <0.00%> (-2.00%)
...com/spotify/heroic/aggregation/simple/MaxBucket.kt 55.55% <0.00%> (+11.11%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 277a082...c09051b. Read the comment docs.