sming commented 4 years ago

IGNORE - TEMP PR - SEEING IF CI RUNS ./checkstyle.xml

sming commented 4 years ago

The error in CI proves that ${basedir}/tools/java.header is being enforced, which in turn proves that ${basedir}/checkstyle.xml is being enforced in CI. Here's the error that I invoked by moving the package declaration above the Spotify legalise header text:

:heroic-core:checkstyleMain (Thread[Daemon worker,5,main]) started.

> Task :heroic-core:checkstyleMain
Excluding []
Task ':heroic-core:checkstyleMain' is not up-to-date because:
  No history is available.
[ant:checkstyle] /home/circleci/project/heroic-core/src/main/java/com/spotify/heroic/http/query/QueryResource.java:1: error: Line does not match expected header line of '/*'.

This in fact tallies with what @malish8632 , @ao2017 and I observed as part of @ao2017's PR review. This is because "incorrect" indentation is not flagged by our checkstyle ruleset. Locally I found that the below inconsistently-indented code was not flagged:


import javax.ws.rs.core.MediaType;
    import org.apache.commons.lang3.tuple.Triple; // wrong indent

// too many lines between statements

@Path("query")
@Produces(MediaType.APPLICATION_JSON)
@Consumes(MediaType.APPLICATION_JSON)
public class QueryResource {
        private final JavaxRestFramework httpAsync;   // wrong indent
    private final QueryManager query;

sming commented 4 years ago

closing as experiment is complete.

spotify / heroic