search

spotify / heroic

The Heroic Time Series Database
https://spotify.github.io/heroic/
Apache License 2.0
848 stars 109 forks source link

Codestyle: update from 6.x to 8.x (see precursor #720) #726

Closed sming closed 3 years ago

sming commented 3 years ago

Codestyle: update from 6.x to 8.x #726

Use Case Resolved: start process of tidying up codebase

NOTE: this just updates checkstyle from 6.x to 8.x. The major piece of work remaining is to correct all the offending code.

Design & Implementation Notes

Use Case Resolved: avoidable debate during code review that wastes time

Design & Implementation Notes

codecov[bot] commented 3 years ago

Codecov Report

Merging #726 (5b67913) into master (6c472e3) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #726   +/-   ##
=========================================
  Coverage     54.94%   54.95%           
- Complexity     3103     3104    +1     
=========================================
  Files           739      739           
  Lines         20143    20143           
  Branches       1312     1312           
=========================================
+ Hits          11067    11069    +2     
+ Misses         8608     8607    -1     
+ Partials        468      467    -1
Impacted Files Coverage Δ Complexity Δ
...m/spotify/heroic/http/tracing/OpenCensusUtils.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ic/metric/bigtable/api/BigtableDataClientImpl.java 20.77% <ø> (ø) 4.00 <0.00> (ø)
...ain/java/com/spotify/heroic/shell/QuoteParser.java 71.11% <100.00%> (ø) 24.00 <0.00> (ø)
...com/spotify/heroic/aggregation/simple/MinBucket.kt 55.55% <0.00%> (+11.11%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c472e3...5b67913. Read the comment docs.