spotify / heroic

The Heroic Time Series Database
https://spotify.github.io/heroic/
Apache License 2.0
848 stars 109 forks source link

Add distribution query integration test. (Part 2 of 2) #737

Closed ao2017 closed 3 years ago

ao2017 commented 3 years ago

This PR adds integration test for distributions query.

codecov[bot] commented 3 years ago

Codecov Report

Merging #737 (a3d2340) into master (037a871) will increase coverage by 0.21%. The diff coverage is 88.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #737      +/-   ##
============================================
+ Coverage     54.82%   55.04%   +0.21%     
- Complexity     3105     3128      +23     
============================================
  Files           742      743       +1     
  Lines         20191    20231      +40     
  Branches       1313     1317       +4     
============================================
+ Hits          11070    11136      +66     
+ Misses         8653     8620      -33     
- Partials        468      475       +7     
Impacted Files Coverage Δ Complexity Δ
...va/com/spotify/heroic/metric/MetricCollection.java 66.66% <ø> (+3.50%) 12.00 <0.00> (ø)
...fy/heroic/aggregation/ComputeDistributionStat.java 64.28% <64.28%> (ø) 1.00 <1.00> (?)
...potify/heroic/aggregation/AggregationCombiner.java 96.77% <100.00%> (+11.05%) 8.00 <8.00> (+7.00)
...ic/aggregation/DistributedAggregationCombiner.java 100.00% <100.00%> (ø) 7.00 <0.00> (+1.00)
...st/src/main/java/com/spotify/heroic/test/Data.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...src/main/java/com/spotify/heroic/QueryOptions.java 60.46% <0.00%> (-4.66%) 4.00% <0.00%> (ø%)
.../com/spotify/heroic/metric/LocalMetricManager.java 64.58% <0.00%> (-1.49%) 4.00% <0.00%> (ø%)
...potify/heroic/aggregation/GroupingAggregation.java 76.92% <0.00%> (+4.61%) 8.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 037a871...a3d2340. Read the comment docs.

lmuhlha commented 3 years ago

implementation lgtm, just some small fixes