search

spotify / lighthouse-audit-service

Apache License 2.0
95 stars 30 forks source link

feat(api): allow user to pass in puppeteer args #80

Closed mayigrin closed 2 years ago

mayigrin commented 2 years ago

Modify triggerAudit and runAudit so that users can pass in args to be used in puppeteer.launch.

This change would enable users to run audits in incognito mode (since caching can potentially lead to inconsistent audit results), as well as make other modifications to the puppeteer browser being used to run the audit.

louisscruz commented 2 years ago

cc @kaimallea

kaimallea commented 2 years ago

@mayigrin awesome, thank you for your contribution! I'll merge into the develop branch, so that I can do a single release with dependency updates.

heresandyboy commented 2 years ago

Hi, is there anything preventing this PR from being completed? I am hoping this feature will allow me to try and figure out a way to resolve this issue: LHError: PROTOCOL_TIMEOUT #70