search

spotify / luigi

Luigi is a Python module that helps you build complex pipelines of batch jobs. It handles dependency resolution, workflow management, visualization etc. It also comes with Hadoop support built in.
Apache License 2.0
17.71k stars 2.39k forks source link

fix: using default_scheduler_url as a mounting point for not root path #3214

Closed franckOL closed 1 year ago

franckOL commented 1 year ago

(http://address/mount) behind proxy works. fix #3213

Signed-off-by: ROUDET Franck INNOV/IT-S franck.roudet@orange.com

Description

2 files modified to change the build of URL. api path not at root now, it is in fact the same strategy that use the GUI.

Motivation and Context

Fixes:

franckOL commented 1 year ago

I don't know how to test with tox. I test locally GUI and API both with mounting point and at root.

franckOL commented 1 year ago

@dlstadther What do you think about that PR ?

dlstadther commented 1 year ago

@franckOL , you'll need to look into and fix any failing tests as a result of this change.

franckOL commented 1 year ago

Not seeing how to fix codeconv. I think my changes are not visible in codecov. and for failed @github-actions Build / core (3.9, py39-core) (pull_request), Not understanding what happens ! network issue :-)