spotify / luigi

Luigi is a Python module that helps you build complex pipelines of batch jobs. It handles dependency resolution, workflow management, visualization etc. It also comes with Hadoop support built in.
Apache License 2.0
17.85k stars 2.39k forks source link

Do not escape <br> tags in task tooltips, so that the line breaks are… #3250

Closed ewallace-RI closed 1 year ago

ewallace-RI commented 1 year ago

Description

This is a minor formatting fix for the Task popover text in the Dependency Graph tab of the scheduler GUI.

Motivation and Context

With the XSS fix implemented in #3230, the tooltip text for a task with multiple parameters has the line break tags escaped: image

This change simply escapes the text for each parameter individually, and then joins the escaped strings with the
tags.

Have you tested this? If so, how?

I spun up a scheduler and checked that a simple test task displays correctly. image