search

spotify / missinglink

Build time tool for detecting link problems in java projects
Apache License 2.0
144 stars 27 forks source link

Handle Multi-Release JARs #125

Closed sideeffffect closed 3 years ago

sideeffffect commented 3 years ago

fixes https://github.com/spotify/missinglink/issues/124

/cc @augi @mattnworb

coveralls commented 3 years ago

Coverage Status

Coverage increased (+1.0%) to 79.545% when pulling 2cf06f33c419c7bbf67954882bd557dc532f8cf5 on sideeffffect:Multi-Release-JARs into 0d2d4ab7d88c240ad49c83b35c174c0926564fd4 on spotify:master.

sideeffffect commented 3 years ago

@mattnworb If you don't mind me asking, is there a way to automatically format the code, so that Checkstyle likes it? :pray: Sorry, I'm not a proficient Maven user.

sideeffffect commented 3 years ago

Anyway, this is ready to be merged :tada:

mattnworb commented 3 years ago

@mattnworb If you don't mind me asking, is there a way to automatically format the code, so that Checkstyle likes it? 🙏 Sorry, I'm not a proficient Maven user.

Not that I know of - which is pretty annoying. In newer projects we tend to use https://github.com/coveooss/fmt-maven-plugin which can automatically reformat the code according to style rules (and verify in CI) which is a lot easier - I'll upgrade this project to use this later on after this PR.

mattnworb commented 3 years ago

@sideeffffect I'll push out a release of this and #129 shortly

sideeffffect commented 3 years ago

Awesome news! :bow:

mattnworb commented 3 years ago

0.2.2 should be on its way 🚀 

[INFO] [INFO]  * Upload of locally staged artifacts finished.
[INFO] [INFO]  * Closing staging repository with ID "comspotify-3775".
[INFO]
[INFO] Waiting for operation to complete...
[INFO] ............
[INFO]
[INFO] [INFO] Remote staged 1 repositories, finished with success.
[INFO] [INFO] Remote staging repositories are being released...
[INFO]
[INFO] Waiting for operation to complete...
[INFO] .........
[INFO]
[INFO] [INFO] Remote staging repositories released.
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Reactor Summary for missinglink 0.2.2:
[INFO] [INFO]
[INFO] [INFO] missinglink ........................................ SUCCESS [  7.047 s]
[INFO] [INFO] missinglink-core ................................... SUCCESS [ 32.381 s]
[INFO] [INFO] missinglink-benchmarks ............................. SUCCESS [  6.478 s]
[INFO] [INFO] missinglink-maven-plugin ........................... SUCCESS [02:29 min]
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD SUCCESS
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time:  03:17 min
[INFO] [INFO] Finished at: 2021-02-22T12:30:15-05:00
[INFO] [INFO] ------------------------------------------------------------------------