Use ConcurrentHashMap for caches to enable using Missinglink on multiple projects

spotify / missinglink

Build time tool for detecting link problems in java projects

Apache License 2.0

146 stars 27 forks source link

Use ConcurrentHashMap for caches to enable using Missinglink on multiple projects #129

Closed sideeffffect closed 3 years ago

sideeffffect commented 3 years ago

fixes https://github.com/spotify/missinglink/issues/128 /cc @hanny24

coveralls commented 3 years ago

Coverage remained the same at 78.558% when pulling bb5a4a3d3db15b0b5e31fe44c7f41d70fe6cf0e4 on sideeffffect:enable-concurrency into ab1c2acb9eb9c8c01dd8343f399ec3b23f23b890 on spotify:master.

sideeffffect commented 3 years ago

I have experimentally verified that this indeed fixes the CME when running Missinglink on multiple sub-projects in parallel. This is ready to be merged :tada:

sideeffffect commented 3 years ago

@mattnworb it would be great if you could have a look at this :pray: It's a tiny change, but it will significantly improve the user experience.