search

spotify / missinglink

Build time tool for detecting link problems in java projects
Apache License 2.0
146 stars 27 forks source link

Handle Java -ea versions #168

Closed klaraward closed 3 years ago

klaraward commented 3 years ago

Can't decide if we should go for removing "-ea" or "-.*" ?

mattnworb commented 3 years ago

Can't decide if we should go for removing "-ea" or "-.*" ?

good question - I wonder if using Runtime.Version.parse(String) would be easier / more future-proof, but it seems like that class was only added in version 9

codecov[bot] commented 3 years ago

Codecov Report

Merging #168 (6448bff) into master (b96a163) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
+ Coverage     85.08%   85.10%   +0.01%     
  Complexity      227      227              
============================================
  Files            23       23              
  Lines           845      846       +1     
  Branches        100      100              
============================================
+ Hits            719      720       +1     
  Misses           90       90              
  Partials         36       36
Impacted Files Coverage Δ
...n/java/com/spotify/missinglink/ArtifactLoader.java 81.08% <100.00%> (+0.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b96a163...6448bff. Read the comment docs.

klaraward commented 3 years ago

Can't decide if we should go for removing "-ea" or "-.*" ?

good question - I wonder if using Runtime.Version.parse(String) would be easier / more future-proof, but it seems like that class was only added in version 9

Parsing Java versions is always fun :D

mattnworb commented 3 years ago

@klaraward 0.2.4 with this should be available