spotify / missinglink

Build time tool for detecting link problems in java projects
Apache License 2.0
144 stars 27 forks source link

Maintenance status #49

Open raiju opened 6 years ago

raiju commented 6 years ago

I've been working on a larger PR to improve the S/N ratio a bit to make it practical to use. The two main changes are:

Additionally I implemented a gradle-plugin to make it more useful for my projects.

I've tested this both with local tests & on a real project with satisfactory results. Before I go on and start cleaning up the PR (mainly will need to do some research into Maven; usually use Gradle myself), is there still interest to review/maintain this plugin here? If yes, does Spotify have a public-facing style-guide I can adhere to for this PR?

spkrka commented 6 years ago

That sounds great! We have not spent much time on this recently, but we still use it sometimes, and we'll happily review/merge PRs. As for style-guide, we're mostly using the https://google.github.io/styleguide/javaguide.html (with minor tweaks) so that should be good enough.

(If the PR is reasonably formatted and useful I'd rather merge it and fix up the style myself if necessary rather than miss out on it completely)

I have also had plans on improving the reachability analysis, but found it tricky when there could be reflection involved, and callbacks into your code from third party code.

raiju commented 6 years ago

Sweet, posted the PR. It's a bit of a monster (left out the gradle piece for now), but hope it's useful enough to make it useful to merge. That said, the PR makes no attempt at tackling the reflection problem 😉

alecl commented 3 years ago

@raiju would you consider releasing your fork with gradle support? I'd be interested in checking it out.