Missinglink refactor - Githubissues

raiju commented 6 years ago

Opening this PR now to enable some discussion.

The main changes are:

Field refs are now treated as refs to the static init method of the class in question
Reachability is now done at the method-level
Static fields/methods are differentiated from non-static ones
Type/descriptor caching is now done in an instance (as opposed to in static variables) to ensure memory can be reclaimed if used in longer-running process (e.g. for Gradle)

It's a bit of a big PR; part of it is that I initially started out with a heavier-handed refactor. I reverted some of them to simplify the PR, but it has made splitting up the above-listed changes hard.

Thoughts?

coveralls commented 6 years ago

Coverage decreased (-5.6%) to 83.143% when pulling 9b55f6b8dad8ad5b703831ba47e159758b8d996d on raiju:sk/missinglink-refactor into 8b1c4ffac7228e388c8634d8afd9184c57e4ce52 on spotify:master.

raiju commented 6 years ago

@spkrka Have you had a chance to take a look? I can also break this PR up into a set of chained PRs if you prefer.

spkrka commented 6 years ago

Sorry, I have not had time to look at it yet, but I have it on my todo list!

raiju commented 5 years ago

Closing (lacks reviewer)

spotify / missinglink

Missinglink refactor #50