search

spotify / missinglink

Build time tool for detecting link problems in java projects
Apache License 2.0
146 stars 27 forks source link

Make plugin work on java11 #53

Closed OskarKjellin closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-7.9%) to 77.712% when pulling 8b74f5598bb193f8b2ffa2e0dc09f61f84f503ae on OskarKjellin:java11 into fd349fe49ccfbc00aeb6fc59504a4d77c759d660 on spotify:master.

mattnworb commented 5 years ago

Nice, thanks! Do you think it is worth adding an entry to the Travis CI config to build/run on Java 11 in CI too, for verification?

OskarKjellin commented 5 years ago

@mattnworb That sounds like a good idea! I tried it myself with java11, but have no idea how to do it on Travis CI

mattnworb commented 5 years ago

I believe you just add an entry here:

https://github.com/spotify/missinglink/blob/fd349fe49ccfbc00aeb6fc59504a4d77c759d660/.travis.yml#L9

https://docs.travis-ci.com/user/languages/java/#using-java-10-and-later

mattnworb commented 5 years ago

thanks again! I'll cut a release.

OskarKjellin commented 5 years ago

Cool, thanks for reviewing and fixing the release!

mattnworb commented 5 years ago

released 0.1.2