search

spotify / missinglink

Build time tool for detecting link problems in java projects
Apache License 2.0
146 stars 27 forks source link

remove guava deps from core #56

Closed jto closed 5 years ago

jto commented 5 years ago

Seems like travis is broken :(

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 78.947% when pulling c3e5acdb89dd77d22f71beb6a057d2c7d2d89f00 on jto:julient/remove-guava-from-core into 5d32c53416bc4921b87809448f672d7e59399322 on spotify:master.

mattnworb commented 5 years ago

@jto actually guava is used in https://github.com/spotify/missinglink/blob/master/core/src/main/java/com/spotify/missinglink/datamodel/MethodDescriptors.java and other classes in the package. We should probably remove that usage, but I'm gonna revert this until then.

The build status was green thanks to transitive dependencies, I think.

jto commented 5 years ago

There's something super fishy. The code should have failed to compile. (unless transitive dependency of course...)

mattnworb commented 5 years ago 
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ missinglink-core ---
[INFO] com.spotify:missinglink-core:jar:0.1.5-SNAPSHOT
[INFO] +- javax.annotation:javax.annotation-api:jar:1.3.2:compile
[INFO] +- org.ow2.asm:asm-tree:jar:7.1:compile
[INFO] |  \- org.ow2.asm:asm:jar:7.1:compile
[INFO] +- io.norberg:auto-matter:jar:0.11.0:provided
[INFO] |  +- io.norberg:auto-matter-annotation:jar:0.11.0:provided
[INFO] |  +- com.squareup:javapoet:jar:1.0.0:provided
[INFO] |  +- com.google.guava:guava:jar:18.0:provided
[INFO] |  \- org.modeshape:modeshape-common:jar:3.8.1.Final:provided
[INFO] +- junit:junit:jar:4.12:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] \- org.assertj:assertj-core:jar:1.7.1:test
mattnworb commented 5 years ago

I created #56 to track getting rid of it (and fixing the auto-matter weirdness)