search

spotify / mobius

A functional reactive framework for managing state evolution and side-effects.
https://spotify.github.io/mobius/
Apache License 2.0
1.23k stars 97 forks source link

fix flakiness in Rx tests #122

Closed pettermahlen closed 4 years ago

pettermahlen commented 4 years ago

Some of the tests in the Rx packages did not use stable assertions meaning that they would occasionally fail.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@72d367f). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #122   +/-   ##
=========================================
  Coverage          ?   78.51%           
  Complexity        ?      320           
=========================================
  Files             ?       86           
  Lines             ?     1727           
  Branches          ?      101           
=========================================
  Hits              ?     1356           
  Misses            ?      349           
  Partials          ?       22
Impacted Files Coverage Δ Complexity Δ
...in/java/com/spotify/mobius/test/FirstMatchers.java 81.81% <0.00%> (ø) 5.00% <0.00%> (?%)
...a/com/spotify/mobius/extras/SimpleConnectable.java 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...com/spotify/mobius/rx2/EffectHandlerException.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...ify/mobius/rx3/UnrecoverableIncomingException.java 40.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...tify/mobius/rx/UnrecoverableIncomingException.java 40.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...n/java/com/spotify/mobius/extras/MobiusExtras.java 75.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...c/main/java/com/spotify/mobius/EventProcessor.java 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)
...xtras/connections/MergeConnectablesConnection.java 92.85% <0.00%> (ø) 8.00% <0.00%> (?%)
...ain/java/com/spotify/mobius/MergedEventSource.java 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)
...a/com/spotify/mobius/internal_util/Throwables.java 33.33% <0.00%> (ø) 1.00% <0.00%> (?%)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72d367f...e131a76. Read the comment docs.