search

spotify / pedalboard

🎛 🔊 A Python library for audio.
https://spotify.github.io/pedalboard
GNU General Public License v3.0
5.11k stars 261 forks source link

Feature request/idea: Compressor ratio default > 1.0? #213

Open drscotthawley opened 1 year ago

drscotthawley commented 1 year ago

Peter, I was noticing that the Compressor affect wasn't doing any Compressing for me, no matter how low I set the threshhold parameter. I was perplexed for a lot longer than I care to admit. It hadn't even occurred to me for a while that the "ratio" parameter defaults to 1, i.e. no compression.

Perhaps there's an important reason for this, and perhaps it would be too hard to change now after so many users have been using Pedalboard.

But I wonder how many of us would enjoy a compressor that naturally defaults to doing at least some compression?
(e.g. IDK, a ratio of 5?)

Very low priority. Just an idea. Feel free to close this at your whim.

psobot commented 1 year ago

Good idea! The default comes from the JUCE library, of which Pedalboard is just a wrapper. I'd happily accept pull requests to change Pedalboard's default to something more "noticeable," instead of just relying on the defaults provided by the underlying C++ framework.