spotify / pedalboard

🎛 🔊 A Python library for audio.
https://spotify.github.io/pedalboard
GNU General Public License v3.0
5.23k stars 262 forks source link

Function parameters.keys() of vst3 plugin MAutoPitch not returning all of existing values (probably because of '#' in it's names) #57

Closed kenhepen closed 2 years ago

kenhepen commented 2 years ago
MAutoPitch = load_plugin('C:\Program Files\Common Files\VST3\MeldaProduction\Pitch Shift\MAutoPitch.vst3')
print(MAutoPitch.parameters.keys())

Result: dict_keys(['depth_automatic_tuning', 'speed_automatic_tuning', 'detune_automatic_tuning', 'dry_wet_effects', 'width_effects', 'keep_formants_effects', 'formant_shiift_effects', 'threshold_detector', 'stabilization_detector', 'min_frequency_detector', 'max_frequency_detector', 'c', 'd', 'e', 'f', 'g', 'a', 'b', 'previous_preeset_trigger', 'next_preset_trigger', 'base_frequency_automatic_tuning', 'bypass', 'program'])

And what is really offers plugin: image

The most problem is Scale-block missing. I suppose it's because of '#' cymbol. parameters.keys() skips it or ignores or something like this. And even if it exists, next problem will be:

# MAutoPitch.c = False
# MAutoPitch.c# = True - THIS
# MAutoPitch.d = True
# MAutoPitch.d# = False - AND THIS

At the same time i can turn plugin state to number-style (with Cockos Reaper) and there are much more parameters including '#'-named: image

kenhepen commented 2 years ago

The same issue with another plugin, Auburn Sounds Graillon 2: dict_keys(['bypass', 'preset', 'lead_gain_db', '2nd_sub_octave_amount_db', '2nd_sub_fifth_amount_db', '1st_sub_octave_amount_db', '1st_sub_fifth_amount_db', 'dry_wet', 'dry_mix_db', 'low_cut_frequency_hz', 'output_level_db', 'placebo', 'bitdepth', 'quantize', 'ring_mode', 'mod_octave_oct', 'mono_reduction', 'pitch_shift_st', 'preserve_formants', 'correction', 'pitch_smoothing_ms', 'snap_range_st', 'reference_hertz', 'inertia', 'allow_c', 'allow_d', 'allow_e', 'allow_f', 'allow_g', 'allow_a', 'allow_b', 'inv_2nd_sub_octave', 'inv_2nd_sub_quint', 'inv_1st_sub_octave', 'inv_1st_sub_quint'])

Check allow_a, allow_b, allow_c and so on, and there are same parameters in plugin, look at allow_c#, allow_d# and others: 2022-01-01 22_24_11-FX_ Track 2 _2_

psobot commented 2 years ago

Thanks @kenhepen! I've opened #58 to fix this - you can expect this to be resolved in version 0.3.10, which will be released shortly.

kenhepen commented 2 years ago

Wow, that was fast! Great, thanks!

пн, 3 янв. 2022 г. в 21:59, Peter Sobot @.***>:

Closed #57 https://github.com/spotify/pedalboard/issues/57 via #58 https://github.com/spotify/pedalboard/pull/58.

— Reply to this email directly, view it on GitHub https://github.com/spotify/pedalboard/issues/57#event-5836723268, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDVZJ3UPD6CSY3PJH6NW2LUUHW2XANCNFSM5LCVNVAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

kenhepen commented 2 years ago

Hi! Pedalboard is powerful and great thing! Thanks for it!

Now it seems like extracting waves plugins from shell is not so easy? I talk about this: https://github.com/spotify/pedalboard/issues/16

I want to try to make it by myself, so what can you recommend to start with? Something general would be enough, I'll google it. I just don't know where to start to dig it.

пн, 3 янв. 2022 г. в 21:59, Peter Sobot @.***>:

Closed #57 https://github.com/spotify/pedalboard/issues/57 via #58 https://github.com/spotify/pedalboard/pull/58.

— Reply to this email directly, view it on GitHub https://github.com/spotify/pedalboard/issues/57#event-5836723268, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDVZJ3UPD6CSY3PJH6NW2LUUHW2XANCNFSM5LCVNVAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>