search

spotify / polly-jest-presets

Apache License 2.0
64 stars 10 forks source link

feat: allow warning before expiry #5

Closed sankaritan closed 5 years ago

sankaritan commented 5 years ago

Feature: adding a script that projects importing this preset can use, typically in a pre-commit husky hook, in order to verify whether any of Polly recordings will expire soon.

This is based on the feedback when engineers could get occasionally blocked from merging new changes without warning because of recordings have expired (though they were unrelated to their changes). The problem is this can prevent urgent fixes to be rolled out if needed. Warning engineers few days ahead should at least partially alleviate those problems.

image

Please take a look @fastfrwrd @charlie-rudenstal @alde @agraves @palmerj3 @kaimallea @javoire @nissayeva!

alde commented 5 years ago

I like it :-)

sankaritan commented 5 years ago

@alde @kaimallea @agraves fixed review comments added tests and documentation. Please check!

spotify-build commented 5 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: