spotify / scio

A Scala API for Apache Beam and Google Cloud Dataflow.
https://spotify.github.io/scio
Apache License 2.0
2.55k stars 514 forks source link

Improve accuracy of FixQuery rule #5438

Closed clairemcginty closed 1 month ago

clairemcginty commented 1 month ago

The accuracy of FixQuery was not good when used on @BigQueryType.from macros. By matching on the <macro>.query.from expression, we can pick up on the macro class's ClassSignature, which includes HasQuery as a parent.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.11%. Comparing base (ce2825a) to head (aabb5c7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5438 +/- ## ======================================= Coverage 61.11% 61.11% ======================================= Files 311 311 Lines 11075 11075 Branches 764 764 ======================================= + Hits 6768 6769 +1 + Misses 4307 4306 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.