search

spotify / semantic-metrics

Capturing meaningful metrics in your Java application
Apache License 2.0
66 stars 36 forks source link

Split packages between core and api modules #60

Open rouzwawi opened 4 years ago

rouzwawi commented 4 years ago

I'm trying to use this library in a project that uses JPMS, but run into issues because the package com.spotify.metrics.core is split between two modules, core and api.

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] error: the unnamed module reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module jsr305 reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module auto.value.annotations reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module awaitility reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module slf4j.api reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module com.google.common reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module okio reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module protobuf.java reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module metrics.core reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module semantic.metrics.api reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module com.spotify.apollo.hermes reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module com.spotify.hermes reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module semantic.metrics.core reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
[ERROR] error: module com.spotify.apollo reads package com.spotify.metrics.core from both semantic.metrics.api and semantic.metrics.core
lmuhlha commented 4 years ago

Thanks for reporting this. We haven't prioritized a fix for this yet, but PRs are always welcome! We'll update this ticket once a solution is in progress on our end.