search

spotify / spotify-tensorflow

Provides Spotify-specific TensorFlow helpers
Apache License 2.0
124 stars 25 forks source link

Expose validate_statistics parameters #189

Closed martin-laurent closed 5 years ago

andrewsmartin commented 5 years ago

@martin-laurent can you fix the flake8 and mypy issues?

codecov[bot] commented 5 years ago

Codecov Report

Merging #189 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   89.09%   89.11%   +0.01%     
==========================================
  Files          12       12              
  Lines         743      744       +1     
==========================================
+ Hits          662      663       +1     
  Misses         81       81
Impacted Files Coverage Δ
spotify_tensorflow/tfx/tfdv.py 94.02% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3761770...172b8fb. Read the comment docs.

brianmartin commented 5 years ago

(@martin-laurent Quick note that tox -e mypy for running locally)