Client Credentials: wrong documentation and unnecessary code Authorization scopes

spotify / spotify-web-api-ts-sdk

A Typescript SDK for the Spotify Web API with types for returned data.

Other

355 stars 68 forks source link

Client Credentials: wrong documentation and unnecessary code Authorization scopes #95

Open Ximzend opened 9 months ago

Ximzend commented 9 months ago

The README and this post show const sdk = SpotifyApi.withClientCredentials("client-id", "secret", ["scope1", "scope2"]);
This is wrong, because Client Credentials do not- and can not use Authorization scopes.
At least ClientCredentialsStrategy.ts contains unnecessary, unused code. The value of scopes is not used in the finale request.

KirtanSoni commented 8 months ago

Can I work on the issue? it seems pretty straightforward. ( I was using the API and came across this issue)