spotify / styx

"The path to execution", Styx is a service that schedules batch data processing jobs in Docker containers on Kubernetes.

Apache License 2.0

267 stars 50 forks source link

Refactor max running timeout to timeout config #1048

Closed sonjaer closed 1 year ago

sonjaer commented 1 year ago

Hey, I just made a Pull Request!

Refactor after feedback https://github.com/spotify/styx/pull/1041

Description

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

[ ] Changes are covered by unit test
[ ] All tests pass
[ ] Code coverage check passes
[ ] Error handling is tested
[ ] Errors are handled at the appropriate layer
[ ] Errors that cannot be handled where they occur are propagated
[ ] (optional) Changes are covered by system test
[ ] Relevant documentation updated
[ ] This PR has NO breaking change to public API
[ ] This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

[ ] This PR has been incorporated in release note for the coming version
[ ] Risky changes introduced by this PR have been all considered

codecov[bot] commented 1 year ago

Codecov Report

Merging #1048 (ae06eb5) into master (0cc1fa2) will increase coverage by 0.16%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1048      +/-   ##
============================================
+ Coverage     92.37%   92.53%   +0.16%     
- Complexity     2137     2141       +4     
============================================
  Files           200      200              
  Lines          8284     8282       -2     
  Branches        502      502              
============================================
+ Hits           7652     7664      +12     
+ Misses          517      505      -12     
+ Partials        115      113       -2