spotify / styx

"The path to execution", Styx is a service that schedules batch data processing jobs in Docker containers on Kubernetes.
Apache License 2.0
267 stars 50 forks source link

Override arch to work around compiling on Apple silicon #1062

Closed honnix closed 1 year ago

honnix commented 1 year ago

Hey, I just made a Pull Request!

Description

Override arch to work around compiling on Apple silicon

Motivation and Context

The gRPC and protobuf deps we are using now are not compatible with Apple silicon, and upgrading those is not trivial (see https://github.com/spotify/styx/pull/1061). This introduce a workaround so that we can compile on Apple silicon.

Reference: https://github.com/trustin/os-maven-plugin#generated-properties

Have you tested this? If so, how?

Checklist for PR author(s)

Checklist for PR reviewer(s)

codecov[bot] commented 1 year ago

Codecov Report

Merging #1062 (1c50a47) into master (afa44b4) will increase coverage by 0.04%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1062      +/-   ##
============================================
+ Coverage     92.29%   92.33%   +0.04%     
+ Complexity     2149     2148       -1     
============================================
  Files           200      200              
  Lines          8314     8314              
  Branches        502      502              
============================================
+ Hits           7673     7677       +4     
+ Misses          526      521       -5     
- Partials        115      116       +1