spotify / styx

"The path to execution", Styx is a service that schedules batch data processing jobs in Docker containers on Kubernetes.

Apache License 2.0

267 stars 50 forks source link

Add deadline to flyte grpc client #1069

Closed pablocasares closed 1 year ago

pablocasares commented 1 year ago

Hey, I just made a Pull Request!

Description

Add a deadline for grpc flyte client calls.

Motivation and Context

This change is required to avoid Styx keeping broken connections for a long time generating a thread starvation problem.

Have you tested this? If so, how?

Checklist for PR author(s)

[ ] Changes are covered by unit test
[ ] All tests pass
[x] Code coverage check passes
[ ] Error handling is tested
[ ] Errors are handled at the appropriate layer
[ ] Errors that cannot be handled where they occur are propagated
[ ] (optional) Changes are covered by system test
[ ] Relevant documentation updated
[x] This PR has NO breaking change to public API
[ ] This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

[ ] This PR has been incorporated in release note for the coming version
[ ] Risky changes introduced by this PR have been all considered