spotify / styx

"The path to execution", Styx is a service that schedules batch data processing jobs in Docker containers on Kubernetes.
Apache License 2.0
267 stars 50 forks source link

chore: upgrading vulnerable packages #1079

Closed trutx closed 1 year ago

trutx commented 1 year ago

Hey, I just made a Pull Request!

Description

This PR upgrades a couple of packages affected by some vulnerabilities.

Jackson packages depend on org.yaml:snakeyaml which is affected by CVE-2022-1471, while spring-expression package is affected by CVE-2023-20863. The packages this PR upgrades to have these vulnerabilities fixed.

There is a side effect: in spring-framework v5.3.27 they also introduced a SpEL expression length limit of 10000 characters. There are a couple of occurrences where we use Strings.repeat(foo, 1024) which generates a too long SpEL. I'm reducing that to 512, which makes string-framework happy again but is still over the 256 limit we have set for our tests, meaning the expectedErrors are still the same and hence tests pass.

Motivation and Context

Resolving vulnerabilities.

Have you tested this? If so, how?

No new features, just fix version upgrades so current tests are valid.

Checklist for PR author(s)

Checklist for PR reviewer(s)