spotify / styx

"The path to execution", Styx is a service that schedules batch data processing jobs in Docker containers on Kubernetes.
Apache License 2.0
267 stars 50 forks source link

Retry in flyteadmin client #1081

Closed sonjaer closed 1 year ago

sonjaer commented 1 year ago

Hey, I just made a Pull Request!

Description

A user got an error on their execution where Styx failed to create execution on Flyte due to 503 errors. This PR adds retries to retry when 5xx errors are receieved

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

Checklist for PR reviewer(s)

codecov[bot] commented 1 year ago

Codecov Report

Merging #1081 (792cda0) into master (69aa2e7) will decrease coverage by 0.11%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1081      +/-   ##
============================================
- Coverage     92.41%   92.30%   -0.11%     
  Complexity     2150     2150              
============================================
  Files           200      200              
  Lines          8321     8321              
  Branches        503      503              
============================================
- Hits           7690     7681       -9     
- Misses          517      526       +9     
  Partials        114      114