spotify / styx

"The path to execution", Styx is a service that schedules batch data processing jobs in Docker containers on Kubernetes.

Apache License 2.0

267 stars 50 forks source link

Handle GCP project not found #1092

Closed honnix closed 1 year ago

honnix commented 1 year ago

Hey, I just made a Pull Request!

Description

Handle GCP project not found correctly.

Motivation and Context

GCP will never return 404 in case of project not found, due to security reason. So we need to treat 403 as 404 for some case.

I also did some small refactorings along the way.

Have you tested this? If so, how?

I updated existing tests to reflect this change.

Checklist for PR author(s)

[x] Changes are covered by unit test
[x] All tests pass
[ ] Code coverage check passes
[x] Error handling is tested
[x] Errors are handled at the appropriate layer
[x] Errors that cannot be handled where they occur are propagated
[ ] (optional) Changes are covered by system test
[ ] Relevant documentation updated
[ ] This PR has NO breaking change to public API
[ ] This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

[ ] This PR has been incorporated in release note for the coming version
[ ] Risky changes introduced by this PR have been all considered

codecov[bot] commented 1 year ago

Codecov Report

Merging #1092 (bb70f26) into master (dcec378) will increase coverage by 0.03%. The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master    #1092      +/-   ##
============================================
+ Coverage     92.33%   92.37%   +0.03%     
- Complexity     2150     2152       +2     
============================================
  Files           200      200              
  Lines          8326     8325       -1     
  Branches        504      504              
============================================
+ Hits           7688     7690       +2     
+ Misses          522      521       -1     
+ Partials        116      114       -2