spotify / styx

"The path to execution", Styx is a service that schedules batch data processing jobs in Docker containers on Kubernetes.

Apache License 2.0

267 stars 50 forks source link

Refactor exceptions and yaml parser #1094

Closed pablocasares closed 1 year ago

pablocasares commented 1 year ago

Hey, I just made a Pull Request!

Description

This PR is a refactor of #1093

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

[ ] Changes are covered by unit test
[ ] All tests pass
[ ] Code coverage check passes
[ ] Error handling is tested
[ ] Errors are handled at the appropriate layer
[ ] Errors that cannot be handled where they occur are propagated
[ ] (optional) Changes are covered by system test
[ ] Relevant documentation updated
[ ] This PR has NO breaking change to public API
[ ] This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

[ ] This PR has been incorporated in release note for the coming version
[ ] Risky changes introduced by this PR have been all considered

codecov[bot] commented 1 year ago

Codecov Report

Merging #1094 (eaad196) into master (705bab4) will increase coverage by 0.02%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1094      +/-   ##
============================================
+ Coverage     92.26%   92.28%   +0.02%     
  Complexity     2150     2150              
============================================
  Files           200      200              
  Lines          8325     8325              
  Branches        504      504              
============================================
+ Hits           7681     7683       +2     
+ Misses          528      527       -1     
+ Partials        116      115       -1