search

spotify / voyager

🛰️ An approximate nearest-neighbor search library for Python and Java with a focus on ease of use, simplicity, and deployability.
https://spotify.github.io/voyager/
Apache License 2.0
1.3k stars 53 forks source link

Return a set() from EnumClassStubsGenerator.get_involved_modules_names. #16

Closed psobot closed 1 year ago

markkohdev commented 1 year ago

For reference this bug resolves this error which occurs when generate_type_stubs_and_docs is run

Generating type stubs from native code...
[2023-06-29 07:53:48,514] {__init__.py:884} DEBUG - Parsing 'voyager' module
Traceback (most recent call last):
  File "/Users/markkoh/.pyenv/versions/3.8.12/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/markkoh/.pyenv/versions/3.8.12/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/markkoh/spotify/voyager/python/scripts/generate_type_stubs_and_docs.py", line 398, in <module>
    main()
  File "/Users/markkoh/spotify/voyager/python/scripts/generate_type_stubs_and_docs.py", line 291, in main
    pybind11_stubgen_main(["-o", "voyager", "voyager", "--no-setup-py", "--log-level", "DEBUG"])
  File "/Users/markkoh/.pyenv/versions/voyager/lib/python3.8/site-packages/pybind11_stubgen/__init__.py", line 1156, in main
    _module.write()
  File "/Users/markkoh/.pyenv/versions/voyager/lib/python3.8/site-packages/pybind11_stubgen/__init__.py", line 1018, in write
    init_pyi.write("\n".join(self.to_lines()))
  File "/Users/markkoh/.pyenv/versions/voyager/lib/python3.8/site-packages/pybind11_stubgen/__init__.py", line 982, in to_lines
    used_modules = sorted(self.get_involved_modules_names())
  File "/Users/markkoh/.pyenv/versions/voyager/lib/python3.8/site-packages/pybind11_stubgen/__init__.py", line 949, in get_involved_modules_names
    result |= C.get_involved_modules_names()
TypeError: unsupported operand type(s) for |=: 'set' and 'list'