The issue is that GitHub Actions secrets aren't used for PRs from forks:
Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.
Our build setup passes MAVEN_GPG_PASSPHRASE into the build at test time, even though it's not needed; and when receiving a PR from an external collaborator, the variable is empty:
We don't need to GPG-sign the package just to test it, given that the default Maven lifecycle is
validate, compile, test, package, verify, install, deploy (in that order). This PR attempts to fix the issue by switching from mvn verify to mvn test.
Should resolve the issue seen in #35.
The issue is that GitHub Actions secrets aren't used for PRs from forks:
Our build setup passes
MAVEN_GPG_PASSPHRASE
into the build at test time, even though it's not needed; and when receiving a PR from an external collaborator, the variable is empty:We don't need to GPG-sign the package just to test it, given that the default Maven lifecycle is
validate
,compile
,test
,package
,verify
,install
,deploy
(in that order). This PR attempts to fix the issue by switching frommvn verify
tomvn test
.