spotify / voyager

🛰️ An approximate nearest-neighbor search library for Python and Java with a focus on ease of use, simplicity, and deployability.
https://spotify.github.io/voyager/
Apache License 2.0
1.26k stars 51 forks source link

Added getNumElements + getVector #64

Closed samek closed 4 months ago

samek commented 4 months ago

As reported in issues https://github.com/spotify/voyager/issues/3 inserting string vector with the same name doesn't update it but it adds another one.

I've modified inserting so that it checks for the key before adding it to the index.

If this change is not wanted I could maybe create upsertItem upsertItems which would perform this way.

samek commented 4 months ago

Ok, I've removed the functionality. But I'm keen on making this until we have whole string index in C++ core. What did you have in mind should we use ConcurrentHashMap ?