search

spotify2tidal / spotify_to_tidal

A command line tool for importing your Spotify playlists into Tidal
GNU Affero General Public License v3.0
295 stars 55 forks source link

Sync favorites #14

Closed bloedboemmel closed 5 months ago

bastianandre commented 8 months ago

It seems the SpotifyOAuth now also needs an additional 'user-top-read' scope to access the /me/top/tracks. Otherwise it fails with 403.

timrae commented 5 months ago

Hi thanks for your contribution, as I'm unable to commit the time to maintaining this repo by myself, I've decided to make a new public project. Please submit your PRs to the new project: https://github.com/spotify2tidal/spotify_to_tidal

timrae commented 4 months ago

By the way, I'm really sorry that I never responded properly to this PR. Actually I would love to support this feature, I think it's a great improvement, however I wasn't really happy enough with the implementation to accept the PR, and didn't have the capacity at that time to explain what needed to change. In particular, there is a lot of logic that is copy-pasted from other parts of the code instead of refactoring the common functionality into reusable functions.

If you or anyone else is interested in re-implementing this feature, please let me know before you start working on it (e.g. in the #9 thread) and we can discuss what is the best approach to solving this problem. For example I would strongly recommend that we split up the existing sync_playlist() function into the parts that are common for both ordinary playlists and favourite tracks (e.g. something like sync_tracks()), and the rest which is specific to playlists. Then add a new function sync_favourites() which implements only the favourite specific logic, and calls the common function.

timrae commented 3 months ago

This feature is on main now, please test it and let us know any feedback