search

spotify2tidal / spotify_to_tidal

A command line tool for importing your Spotify playlists into Tidal
GNU Affero General Public License v3.0
241 stars 44 forks source link

Use singleton for TIDAL cache #36

Closed joshrmcdaniel closed 1 month ago

joshrmcdaniel commented 1 month ago

Modify TidalPlaylistCache to be a singleton. If TidalPlaylistCache is reinitiated, it will return the existing object

timrae commented 1 month ago

I've been testing this a bit today, and did the work to pull out just the new cache part from this PR (and pushed that to a new branch via #39). Could you use that as a base for any further changes?

timrae commented 1 month ago

I added another cache to complement this #41, which caches the track ids that failed to match. Please take a look.

timrae commented 1 month ago

Hey @joshrmcdaniel This PR has really motivated me to do some more performance optimisations, I think it's better for me to take over from here if all good with you? I'll put up a new PR shortly

joshrmcdaniel commented 1 month ago

@timrae No problem

timrae commented 1 month ago

Awesome, I'll close this then, please take a look at #43, and let me know if anything has gotten lost or broken