search

spotify2tidal / spotify_to_tidal

A command line tool for importing your Spotify playlists into Tidal
GNU Affero General Public License v3.0
295 stars 55 forks source link

Sync favorites #63

Closed timrae closed 3 months ago

timrae commented 3 months ago

Continuation of #55 from @c0ball with some cleanups and various fixes from me

Closes #14

c0ball commented 3 months ago

This looks good to me, but I would definitely update the README, as the usage of sync-favorites and disable-sync-favorites is in my opinion a bit confusing. Maybe we should change sync-favorites to sync-favorites-only.

c0ball commented 3 months ago

I am not sure whether this issue is tied to this feature specifically. But when I tried to synchronize a Spotify playlist with 106 songs, 106 were searched for on Tidal, but only 104 were added, and no red error message (this one: "Could not find track...) appeared for the two not synchronized, which is normally the case, isn't it?!

timrae commented 3 months ago

I am not sure whether this issue is tied to this feature specifically. But when I tried to synchronize a Spotify playlist with 106 songs, 106 were searched for on Tidal, but only 104 were added, and no red error message (this one: "Could not find track...) appeared for the two not synchronized, which is normally the case, isn't it?!

Hmm are there any duplicates on the playlist? Duplicates will be filtered out. If that's not it could you try to come up with a reproduction test case?

c0ball commented 3 months ago

I will verify this, but not today anymore ;)

c0ball commented 3 months ago

I am not sure whether this issue is tied to this feature specifically. But when I tried to synchronize a Spotify playlist with 106 songs, 106 were searched for on Tidal, but only 104 were added, and no red error message (this one: "Could not find track...) appeared for the two not synchronized, which is normally the case, isn't it?!

Hmm are there any duplicates on the playlist? Duplicates will be filtered out. If that's not it could you try to come up with a reproduction test case?

I can confirm that these were indeed duplicates. Maybe we should add an output indicating that x songs were ignored due to duplicates, otherwise the user might be confused why the number of added songs is not the same.

c0ball commented 3 months ago

I am not sure whether this issue is tied to this feature specifically. But when I tried to synchronize a Spotify playlist with 106 songs, 106 were searched for on Tidal, but only 104 were added, and no red error message (this one: "Could not find track...) appeared for the two not synchronized, which is normally the case, isn't it?!

Hmm are there any duplicates on the playlist? Duplicates will be filtered out. If that's not it could you try to come up with a reproduction test case?

I can confirm that these were indeed duplicates. Maybe we should add an output indicating that x songs were ignored due to duplicates, otherwise the user might be confused why the number of added songs is not the same.

I created #64 which prints the name of each duplicate and the total number of duplicates