spotinst / spotinst-kubernetes-helm-charts

Official repository for all Spot by NetApp Kubernetes Helm Charts.
Apache License 2.0
19 stars 26 forks source link

Spotinst helm chart installs metrics server #1

Closed estahn closed 5 years ago

estahn commented 5 years ago
Upgrading spotinst/spotinst-kubernetes-cluster-controller
Release "spotinst" does not exist. Installing it now.
Error: release spotinst failed: clusterroles.rbac.authorization.k8s.io "system:metrics-server-aggregated-reader" already exists
-
+ # Source: spotinst-kubernetes-cluster-controller/charts/metrics-server/templates/aggregated-metrics-reader-cluster-role.yaml
+ kind: ClusterRole
+ apiVersion: rbac.authorization.k8s.io/v1
+ metadata:
+   name: system:metrics-server-aggregated-reader
+   labels:
+     app: metrics-server
+     chart: metrics-server-2.5.0
+     release: spotinst
+     heritage: Tiller
+     rbac.authorization.k8s.io/aggregate-to-view: "true"
+     rbac.authorization.k8s.io/aggregate-to-edit: "true"
+     rbac.authorization.k8s.io/aggregate-to-admin: "true"
+ rules:
+   - apiGroups: ["metrics.k8s.io"]
+     resources: ["pods"]
+     verbs: ["get", "list", "watch"]
liranp commented 5 years ago

You can set the deployChart value to false and skip the installation of the metrics-server (see: #2).

estahn commented 5 years ago

@liranp Thanks.

Btw the general convention is:

metrics-server:
  enabled: true

And I would suggest to disable it by default as most Kubernetes cluster will have this already.