search

spotinst / terraform-spotinst-modules

[DEPRECATED] Terraform modules for Spotinst resources.
https://registry.terraform.io/modules/spotinst
Apache License 2.0
6 stars 17 forks source link

Dynamic version #8

Closed Artemu closed 5 years ago

Artemu commented 5 years ago

Implementing dynamic version control to push updates without hard terraform updates.

Currently the version is hard coded and pushing through new versions is not being maintained in the terraform repo. The commit will require a text file in an external source such as S3 to push updates dynamically to the terraform repo.

@todo: Link needs to be updated to reflect a Spotinst data source, for example spotinst-public S3 bucket.

A similar concept is currently used by the Spotinst team to manage the controller as follows kubectl apply -f http://spotinst-public.s3.amazonaws.com/integrations/kubernetes/cluster-controller/spotinst-kubernetes-cluster-controller.yaml

A similar file will need to be created in this S3 bucket for this to be fully implemented and the example link changed in the pull request. The file format as per the pull request is as follows https://s3-eu-west-1.amazonaws.com/spotinst-vers/controller.json

kmcgrath commented 5 years ago

Thank you for the PR. For now we will pull in the latest tag and going forward we will make the version configurable.