search

spotinst / terraform-spotinst-ocean-eks

[Deprecated] A Terraform module to create an Amazon Elastic Kubernetes Service (EKS) cluster with Ocean.
https://registry.terraform.io/modules/spotinst/ocean-eks/spotinst
Apache License 2.0
21 stars 30 forks source link

Additional EKS nodes security nodes not attached to Ocean nodes #14

Closed gastoncan closed 3 years ago

gastoncan commented 3 years ago 
module "ocean-eks" {
  source = "spotinst/ocean-eks/spotinst"
  worker_additional_security_group_ids = ["sg-xxxxxxxxxxx"]
 #redacted
}

When describing my EKS nodes, I don't get my additional SG sg-xxxxxxxxxxx.

Taking a look to the module code, I see the following (ocean.tf): security_groups = [module.eks.worker_security_group_id]

Maybe it should be, something like: security_groups = concat([module.eks.worker_security_group_id], var.worker_additional_security_group_ids)

A great job was done on this TF module, congrats!

liranp commented 3 years ago

Thank you for reporting this, @gastoncan. I've fixed it and released version 1.3.0.

gastoncan commented 3 years ago

Thanks for the quick fix! Appreciate that.