spotinst / terraform-spotinst-ocean-spark

https://registry.terraform.io/modules/spotinst/ocean-spark/spotinst/latest
Apache License 2.0
2 stars 3 forks source link

Incorrect documentation for 3.0.3 #52

Open jasonm3-netapp opened 1 week ago

jasonm3-netapp commented 1 week ago

The README.md for this module appears to be inconsistent with requirements. Previous versions of this module required ocean_cluster_id as the only required variable. It appears there is a new requirement, and the documentation is not up to date for this requirement.

Error: Missing required argument

  on eks-ocean-spark.tf line 291, in module "ocean_spark":
 291: module "ocean_spark" {

The argument "cluster_config" is required, but no definition was found.

Our relevant code:

module "ocean_spark" {
  source  = "spotinst/ocean-spark/spotinst"
  version = "3.0.3"

  providers = {
    kubernetes = kubernetes.time_cube_ocean_spark_kubernetes
    spotinst   = spotinst.ocean_spark
  }

  ocean_cluster_id = module.ocean_aws_k8s.ocean_id
}
Z4ck404 commented 6 days ago

Good catch ... Thanks for reporting this @jasonm3-netapp.