search

spotonlive / laravel-google-ads

Google Ads API for Laravel
MIT License
64 stars 58 forks source link

Dfp Integration #26

Closed ALTELMA closed 7 years ago

ALTELMA commented 7 years ago

For long time since I ever create issue ask you about Dfp integration. Now I ready for new thing on your repository.

Could you please accept my PR?

nikolajlovenhardt commented 7 years ago

You'll need to resolve the conflicts before I'm able to merge.

ALTELMA commented 7 years ago

Ok, I already resolve the conflicts.

jsonUK commented 7 years ago

I've actually made a fork with this change included and confirm it works.

I did make a couple of adjustments so I could override the google-ads.php config options.

Like I wanted to load the refreshToken from a local file so that it could be replaced via a command or a controller.

mmccaff commented 7 years ago

Perfect - I want this exact feature! Can the PR be merged please?

I was just about to start doing similar work myself for a PR, and then found this. :)

mmccaff commented 7 years ago

I wonder what happened to @nikolajlovenhardt ? :)

Could you respond and say if/when you plan to merge this? I'd rather not start a fork but would like to start using the changes in this PR.

(and thanks for the nice package, and also to @ALTELMA for the PR to it.)

nikolajlovenhardt commented 7 years ago

sorry for the delay. I'm going to merge this PR within the next few days

mmccaff commented 7 years ago

Excellent news, thank you!

ALTELMA commented 7 years ago

Still hold on, Why?

nikolajlovenhardt commented 7 years ago

@ALTELMA https://github.com/nikolajlovenhardt/laravel-google-ads/pull/27

Thank you very much and sorry for the delay