search

spotonlive / laravel-google-ads

Google Ads API for Laravel
MIT License
64 stars 58 forks source link

wont install into "laravel/framework": "5.4.*", #30

Closed phillipmadsen closed 6 years ago

phillipmadsen commented 6 years ago

any updates coming?

nikolajlovenhardt commented 6 years ago

@phillipmadsen You are welcome to open a PR

wecodelaravel commented 6 years ago

What do you mean by PR sorry not familiar with it.

nikolajlovenhardt commented 6 years ago

@laravelcoder PR stands for pull request

wecodelaravel commented 6 years ago

ok so your answer to it not working on 5.4 is to do a pull request?

Are you going to update the package so it works for laravel 5.4 with the newer library is what im asking not if i can do it and push it back to you. I would love to add your package to our build but it will not work until you update it.

nikolajlovenhardt commented 6 years ago

@laravelcoder I do not plan to update the package at the moment, but as I said you are welcome to open a PR.

nikolajlovenhardt commented 6 years ago

I just released a fix for 5.4 and 5.5. Please see https://github.com/nikolajlovenhardt/laravel-google-ads/releases/tag/1.2.4