spotonlive / php-google-my-business

Google MyBusiness
Apache License 2.0
29 stars 25 forks source link

orderBy parameter for listAccountsLocations #5

Closed alexp777 closed 6 years ago

alexp777 commented 6 years ago

MyBusiness.php:346 method: v4/{+parent}/locations There is absent 'orderBy' in the parameters array.

This is for the following function: MyBusiness.php:1266 public function listAccountsLocations()

But in the Google refrence it is present. https://developers.google.com/my-business/reference/rest/v4/accounts.locations/list

Could you add 'orderBy' parameter?

nikolajlovenhardt commented 6 years ago

Hi @alexp777

You need to pass the orderBy parameter as a optional parameter.

alexp777 commented 6 years ago

Then there will be an exception

http://nimb.ws/Rjtb6s

2018-09-19 15:06 GMT+03:00, Nikolaj Løvenhardt Petersen notifications@github.com:

Hi @alexp777

You need to pass the orderBy parameter as a optional parameter.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/spotonlive/php-google-my-business/issues/5#issuecomment-422777222

nikolajlovenhardt commented 6 years ago

Good point - I'll look into it. Thank you

JessJNielsen commented 6 years ago

Hi @alexp777

I just upgraded the package to support v4.2 which contains the orderBy parameter.

alexp777 commented 6 years ago

Thank you!