spotty-cloud / spotty

Training deep learning models on AWS and GCP instances
https://spotty.cloud
MIT License
492 stars 43 forks source link

[feature request] Parameter to select EBS volume type #45

Closed vadimkantorov closed 5 years ago

vadimkantorov commented 5 years ago

Currently EBS volumes are created using standard type which corresponds to "previous-generation HDD suitable for infrequently accessed storage". I can convert the volume type in the AWS console, but it would be nice to specify the volume type at its creation.

Also, the EBS volume type standard does not support volumes larger than 1 Tb.

The fix would be adding 'VolumeType' : 'gp2' (or a configurable volume type) at https://github.com/apls777/spotty/blob/master/spotty/providers/aws/deployment/cf_templates/instance_template.py#L114

apls777 commented 5 years ago

Thank you, Vadim! I'll fix it this week.

apls777 commented 5 years ago

Now it's the "gp2" volume type by default and there is the "type" parameter in the volume configuration to be able to change it.

The "io1" volume type is not supported at the moment, it requires an additional parameter: "iops". If you need specifically this volume type, feel free to open another issue.