search

spoulson / Itinerary

Lazy time scheduling toolset for .NET
29 stars 7 forks source link

# DayOfMonth spec not working totally correct #15

Open steventwors opened 9 years ago

steventwors commented 9 years ago

Can be demonstrated using the TDL Explorer tool, this is supposed to be 1st monday of every month:

Start Range: 3/1/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/2/2015, which is correct, but watch what happens when the start date is after 3/2/2015:

Start Range: 3/3/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/9/2015.

All the other dates in the set are correctly the first monday of the month, but the first date returned in the set will always be the next monday from the start range.

spoulson commented 9 years ago

Hello steventwors,

Thanks for pointing out this bug. If you could kindly create a pull request for a fix, I can certainly merge it in.

Can be demonstrated using the TDL Explorer tool, this is supposed to be 1st monday of every month:

Start Range: 3/1/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/2/2015, which is correct, but watch what happens when the start date is after 3/2/2015:

Start Range: 3/3/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/9/2015.

All the other dates in the set are correctly the first monday of the month, but the first date returned in the set will always be the next monday from the start range.

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15

steventwors commented 9 years ago

Sorry, I wasted about 20min going round in circles trying to figure out Github and how to do a pull request. I created my own fork,

-----Original Message----- From: "Shawn Poulson" notifications@github.com Sent: Monday, March 16, 2015 1:44pm To: "spoulson/Itinerary" Itinerary@noreply.github.com Cc: "steventwors" steven@addmembers.com Subject: Re: [Itinerary] # DayOfMonth spec not working totally correct (#15)

Hello steventwors,

Thanks for pointing out this bug. If you could kindly create a pull request for a fix, I can certainly merge it in.

Can be demonstrated using the TDL Explorer tool, this is supposed to be 1st monday of every month:

Start Range: 3/1/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/2/2015, which is correct, but watch what happens when the start date is after 3/2/2015:

Start Range: 3/3/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/9/2015.

All the other dates in the set are correctly the first monday of the month, but the first date returned in the set will always be the next monday from the start range.

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15#issuecomment-81835608

spoulson commented 9 years ago

If you could show me what commit(s) you made in your fork to fix the issue, I will try to incorporate your changes in my repo.

Sorry, I wasted about 20min going round in circles trying to figure out Github and how to do a pull request. I created my own fork,

-----Original Message----- From: "Shawn Poulson" notifications@github.com Sent: Monday, March 16, 2015 1:44pm To: "spoulson/Itinerary" Itinerary@noreply.github.com Cc: "steventwors" steven@addmembers.com Subject: Re: [Itinerary] # DayOfMonth spec not working totally correct (#15)

Hello steventwors,

Thanks for pointing out this bug. If you could kindly create a pull request for a fix, I can certainly merge it in.

Can be demonstrated using the TDL Explorer tool, this is supposed to be 1st monday of every month:

Start Range: 3/1/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/2/2015, which is correct, but watch what happens when the start date is after 3/2/2015:

Start Range: 3/3/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/9/2015.

All the other dates in the set are correctly the first monday of the month, but the first date returned in the set will always be the next monday from the start range.

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15#issuecomment-81835608

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15#issuecomment-82398183

steventwors commented 9 years ago

Oh sorry, I didn't mean to imply I was going to fix it and submit it to the github project, i was merely reporting something i found, that's all.

i was able to workaround this issue. its a great library btw im glad you made it.

-----Original Message----- From: "Shawn Poulson" notifications@github.com Sent: Tuesday, March 17, 2015 11:30am To: "spoulson/Itinerary" Itinerary@noreply.github.com Cc: "steventwors" steven@addmembers.com Subject: Re: [Itinerary] # DayOfMonth spec not working totally correct (#15)

If you could show me what commit(s) you made in your fork to fix the issue, I will try to incorporate your changes in my repo.

Sorry, I wasted about 20min going round in circles trying to figure out Github and how to do a pull request. I created my own fork,

-----Original Message----- From: "Shawn Poulson" notifications@github.com Sent: Monday, March 16, 2015 1:44pm To: "spoulson/Itinerary" Itinerary@noreply.github.com Cc: "steventwors" steven@addmembers.com Subject: Re: [Itinerary] # DayOfMonth spec not working totally correct (#15)

Hello steventwors,

Thanks for pointing out this bug. If you could kindly create a pull request for a fix, I can certainly merge it in.

Can be demonstrated using the TDL Explorer tool, this is supposed to be 1st monday of every month:

Start Range: 3/1/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/2/2015, which is correct, but watch what happens when the start date is after 3/2/2015:

Start Range: 3/3/2015 12:00:00 AM End Range: 6/24/2015 12:00:00 AM cron 0 0 * * 1#1

first date in returned set is 3/9/2015.

All the other dates in the set are correctly the first monday of the month, but the first date returned in the set will always be the next monday from the start range.

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15#issuecomment-81835608

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15#issuecomment-82398183

Reply to this email directly or view it on GitHub: https://github.com/spoulson/Itinerary/issues/15#issuecomment-82414911

spoulson commented 9 years ago

Just following up. Another Github user created a fix that may have addressed your issue. I merged it in, so you may be interested in looking at it again.