search

spox / batali

Light weight cookbook resolver
https://spox.github.io/batali
Other
32 stars 6 forks source link

Only clean asset if asset path is set #82

Closed chrisroberts closed 8 years ago

chrisroberts commented 8 years ago

Fixes issue raised in #81

webframp commented 8 years ago 
C:\src\infra-repo [master ≡ +1 ~3 -0 !]> be batali install
[Batali]: Readying installation destination... complete!
[Batali]: Installing cookbooks... complete!
C:\src\infra-repo [master ≡ +1 ~3 -0 !]> be batali install
[Batali]: Readying installation destination... complete!
[Batali]: Installing cookbooks... error!
[ERROR]: Reason - no implicit conversion of nil into String
ERROR: TypeError: no implicit conversion of nil into String
C:/src/chef/batali/lib/batali/command/install.rb:38:in `join'
C:/src/chef/batali/lib/batali/command/install.rb:38:in `block (5 levels) in execute!'
C:\src\infra-repo [master ≡ +1 ~3 -0 !]> be batali install

Looks like a check is also needed around asset_path in install command, but not sure why asset path would be empty there.

webframp commented 8 years ago

Looking good! :+1: 

[Batali]: Readying installation destination... complete!
[Batali]: Installing cookbooks... [DEBUG]: Starting unit install for: chef-client<4.3.3>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache[DEBUG]: Starting unit install for: cron<1.7.6>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: windows<1.39.2>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: logrotate<1.9.2>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: chef_handler<1.3.0>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: appserver<0.1.5>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: powershell<3.2.3>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: iis<4.1.7>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: ms_dotnet<2.6.1>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache
[DEBUG]: Starting unit install for: octopus<0.2.4>
[DEBUG]: Cache directory to persist cookbooks: C:/Users/SESCRIVA/.batali/cache

[DEBUG]: Completed unit install for: chef_handler<1.3.0>
[DEBUG]: Completed unit install for: ms_dotnet<2.6.1>
[DEBUG]: Completed unit install for: cron<1.7.6>
[DEBUG]: Completed unit install for: powershell<3.2.3>
[DEBUG]: Completed unit install for: chef-client<4.3.3>
[DEBUG]: Completed unit install for: iis<4.1.7>
[DEBUG]: Completed unit install for: logrotate<1.9.2>
[DEBUG]: Completed unit install for: windows<1.39.2>
[DEBUG]: Completed unit install for: appserver<0.1.5>
[DEBUG]: Completed unit install for: octopus<0.2.4>
complete!
chrisroberts commented 8 years ago

windows