merge rebinding protection and block plugin

spr-networks / super

📡 SPR: Open Source, secure, user friendly and fast wifi routers for your home. One wifi password per device. Ad Blocking & Privacy Blocklists. Policy Based Network Access

https://www.supernetworks.org/

BSD 3-Clause "New" or "Revised" License

165 stars 12 forks source link

merge rebinding protection and block plugin #297

Closed lts-rad closed 5 months ago

lts-rad commented 5 months ago

right now an override does not allow an ip under rebinding protection to be permitted. this is not intuitive behavior.

to fix this, the rebinding plugin will be merged into the block plugin.

old behavior:

domain override says yes
rebinding happens next. does not know about override, blocks domain

new behavior:

ui to enable/disable rebinding check under dns settings
when a permit override happens, the rebinding check will not happen.

lts-rad commented 5 months ago

another pain point is the https://coredns.io/plugins/cache/ plugin versus block.

right now it will cache with NXDOMAIN.

looking at the docs, https://coredns.io/plugins/cache/

there is an option to not cache SERVFAIL. but we return NXDOMAIN instead so cant leverage it. doesnt seem like any straight fordard way to evict from cache. one option is to fork the cache plugin and use our own fork for this purpose, and then try to merge the changes upstream.

lts-rad commented 5 months ago

this is now in the dev branch